Refactor right panel header buttons #5117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 25, 2017 14:13
To reduce repetition of code, simplify the process of adding header buttons and remove the need for many handler functions.
|
(I'll squash merge this) |
dbkr
reviewed
Sep 25, 2017
| // If currentPhase is one of the specified phases, the button will be highlighted | ||
| phases: PropTypes.arrayOf(PropTypes.string).isRequired, | ||
| // The currentPhase of the RightPanel | ||
| currentPhase: PropTypes.string.isRequired, |
There was a problem hiding this comment.
Is there likely to be any need for the button to know the actual phases it represents or what the current phase is? Could we just pass in whether it should be highlighted or not?
There was a problem hiding this comment.
Could we just pass in whether it should be highlighted or not?
I was hoping to abstract this logic away such that, for example, we can't get two buttons highlighted at once. It's probably overkill but if every single header button is going to embody this logic, it seems inefficient to dupe it for each one.
There was a problem hiding this comment.
Also, it needs to know for the dispatch so 🤷♂️
added 3 commits
September 25, 2017 16:06
Use isHighlighted as a prop instead of computing based on phases and currentPhase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce repetition of code, simplify the process of adding header buttons and remove the need for many handler functions.